Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement random_element for EquiangularPolygons #61

Closed
videlec opened this issue Sep 15, 2020 · 0 comments · Fixed by #62
Closed

implement random_element for EquiangularPolygons #61

videlec opened this issue Sep 15, 2020 · 0 comments · Fixed by #62

Comments

@videlec
Copy link
Collaborator

videlec commented Sep 15, 2020

When the angles correspond to a convex polygon (ie angle < pi) everything is easy: any non-negative combination of the rays give rise to a non-intersecting polygon. For n=4, one can work out the geometry easily, but starting from n=5 there are some delicate examples such as E = EquiangularPolygons(1,1,1,2,8). This latter example either fails with

  • ValueError: edge [...] and edge [...] intersects or
  • ValueError: the vertices are in clockwise order (which looks like a bug)

The article https://arxiv.org/pdf/2008.10192.pdf might be helpful.
See also #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant