Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saddle connection in cathedral has wrong start and end data #259

Open
saraedum opened this issue Oct 10, 2023 · 1 comment
Open

Saddle connection in cathedral has wrong start and end data #259

saraedum opened this issue Oct 10, 2023 · 1 comment
Labels

Comments

@saraedum
Copy link
Member

In the cathedral(1, 2), I get the following saddle connection:

Saddle connection in direction (0, -1) with start data (1, 8) and end data (1, 3)

At first this seems to be related to #258 but it's probably a different bug since the corresponding flow seems to work fine after fixing #258:

sage: from flatsurf import Polygon
sage: P = Polygon(vertices=[(1, 0), (1, -2), (3/2, -5/2), (2, -2), (2, 0), (2, 1), (2, 3), (3/2, 7/2), (1, 3), (1, 1)])
sage: P.flow_to_exit(vector((1, 3)), vector((0, -1)))
((1, -2), point positioned on vertex 1 of polygon)
@saraedum saraedum added the bug label Oct 10, 2023
@saraedum
Copy link
Member Author

saraedum commented Oct 10, 2023

More precisely, I get

sage: from flatsurf.geometry.saddle_connection import SaddleConnection
sage: from flatsurf import translation_surfaces
sage: S = translation_surfaces.cathedral(1, 2)
sage: SaddleConnection(S, (1, 8), (0, -1))
Saddle connection in direction (0, -1) with start data (1, 8) and end data (1, 3)
# should be: Saddle connection in direction (0, -1) with start data (1, 8) and end data (1, 5)

So the flow (correctly) skips over marked vertices of the polygon. From the polygon perspective "flow to exit" this is correct. However, the flow must stop at singularities here.

@saraedum saraedum reopened this Oct 10, 2023
saraedum added a commit to saraedum/sage-flatsurf that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant