Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: graceful failure from extend/override errors #4134

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Dec 7, 2024

Changes proposed in this pull request:
Reduces forum crashes by gracefully failing from extension logic errors within extend and override callbacks.

Before
Screenshot from 2024-12-07 16-21-06

After
Screenshot from 2024-12-07 16-21-22

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner December 7, 2024 15:30
@luceos luceos merged commit 5d281b9 into 2.x Dec 7, 2024
28 checks passed
@luceos luceos deleted the sm/graceful-failure-from-extend/override-callbacks branch December 7, 2024 20:05
@SychO9 SychO9 added this to the 2.0.0-beta.1 milestone Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants