Fix transaction sign with Ledger

[levoncrypto]

Summary by CodeRabbit

• New Features

  • Added a new "Coins" tab to the graphical user interface, allowing users to manage their coins more effectively.

• Enhancements

  • Improved handling of transaction data in Ledger plugin, including support for transaction.extra_data, enhancing compatibility and data integrity during transactions.

[coderabbitai]

Walkthrough

Recent updates to the Electrum Dash wallet introduce a new "Coins" tab to the GUI for better visibility of UTXOs and enhance the Ledger plugin by incorporating handling for transaction.extra_data. These changes improve user experience and transaction processing capabilities.

Changes

File(s)	Summary of Changes
electrum_dash/gui/qt/main_window.py	Added a new "Coins" tab (Co&ins) to the main window GUI.
electrum_dash/plugins/ledger/ledger.py	Enhanced getTrustedInput method to handle transaction.extra_data, adjusting block lengths and buffer handling for communication with the dongle.

Sequence Diagram

sequenceDiagram
    participant User
    participant MainWindow
    participant LedgerPlugin
    participant Dongle

    User ->>+ MainWindow: Launch Wallet
    MainWindow ->>+ User: Display GUI with "Coins" Tab
    User ->>+ LedgerPlugin: Initiate Transaction
    LedgerPlugin ->> Dongle: Send Transaction Data (including extra_data)
    Dongle -->> LedgerPlugin: Confirm Data Receipt
    LedgerPlugin -->> User: Transaction Processed

Loading

Poem

In the world of code so vast and wide,
A new Coins tab is our guide.
Ledger’s secrets now unfold,
Extra data, handled bold.
Electrum Dash, evolving fast,
A future bright, improvements vast.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

Outside diff range, codebase verification and nitpick comments (2)

electrum_dash/plugins/ledger/ledger.py (2)

154-156: Remove redundant offset adjustment.

The offset adjustment is redundant since it will be set to the length of transaction.extra_data in the next step.

if offset > len(transaction.extra_data):
    offset = len(transaction.extra_data)

---

157-158: Avoid redundant check for transaction.extra_data.

The check for transaction.extra_data is redundant since it is already checked before.

if transaction.extra_data:
    apdu.extend(transaction.extra_data[0: offset])

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e3bd997 and 2924a77.

Files selected for processing (2)

• electrum_dash/gui/qt/main_window.py (1 hunks)
• electrum_dash/plugins/ledger/ledger.py (1 hunks)

Files skipped from review due to trivial changes (1)

• electrum_dash/gui/qt/main_window.py