Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_ui_auth] "Unknown" hardcoded in editable_user_display_name.dart #437

Open
1 task done
alexodus opened this issue Nov 17, 2024 · 1 comment
Open
1 task done
Labels
auth blocked: customer response Waiting for customer response, e.g. more information was requested. platform: all

Comments

@alexodus
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and found no duplicates.

What plugin is this bug for?

Firebase UI Auth

What platform(s) does this bug affect?

Android, iOS, Web, macOS

List of dependencies used.

flutter pub deps -s list
  Dart SDK 3.5.4
Flutter SDK 3.24.4
XXXXX 0.3.0+61

dependencies:

  • flutter 0.0.0
    • characters 1.3.0
    • collection 1.18.0
    • material_color_utilities 0.11.1
    • meta 1.15.0
    • vector_math 2.1.4
    • sky_engine any
  • flutter_localizations 0.0.0
    • flutter any
    • intl 0.19.0
    • characters 1.3.0
    • clock 1.1.1
    • collection 1.18.0
    • material_color_utilities 0.11.1
    • meta 1.15.0
    • path 1.9.0
    • vector_math 2.1.4
  • cupertino_icons 1.0.8
  • firebase_core 3.6.0
    • firebase_core_platform_interface ^5.3.0
    • firebase_core_web ^2.18.1
    • flutter any
    • meta ^1.8.0
  • firebase_crashlytics 4.1.3
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • firebase_crashlytics_platform_interface ^3.6.44
    • flutter any
    • stack_trace ^1.10.0
  • firebase_analytics 11.3.3
    • firebase_analytics_platform_interface ^4.2.5
    • firebase_analytics_web ^0.5.10+2
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • flutter any
  • cloud_firestore 5.4.4
    • cloud_firestore_platform_interface ^6.4.3
    • cloud_firestore_web ^4.3.2
    • collection ^1.0.0
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • flutter any
    • meta ^1.8.0
  • firebase_auth 5.3.1
    • firebase_auth_platform_interface ^7.4.7
    • firebase_auth_web ^5.13.2
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • flutter any
    • meta ^1.8.0
  • firebase_messaging 15.1.3
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • firebase_messaging_platform_interface ^4.5.46
    • firebase_messaging_web ^3.9.2
    • flutter any
    • meta ^1.8.0
  • cloud_functions 5.1.3
    • cloud_functions_platform_interface ^5.5.37
    • cloud_functions_web ^4.10.2
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • flutter any
  • firebase_in_app_messaging 0.8.0+8
    • firebase_core ^3.6.0
    • firebase_core_platform_interface ^5.3.0
    • firebase_in_app_messaging_platform_interface ^0.2.4+44
    • flutter any
    • meta ^1.8.0
  • firebase_ui_shared 1.4.1
    • flutter any
  • firebase_ui_localizations 1.13.0
    • flutter any
    • flutter_localizations any
    • path ^1.8.3
  • firebase_ui_auth 1.16.0
    • email_validator ^2.1.17
    • firebase_auth ^5.3.1
    • firebase_core ^3.6.0
    • firebase_dynamic_links ^6.0.8
    • firebase_ui_localizations ^1.13.0
    • firebase_ui_oauth ^1.6.0
    • firebase_ui_shared ^1.4.1
    • flutter any
    • flutter_localizations any
    • meta ^1.10.0
  • firebase_ui_firestore 1.7.0
    • cloud_firestore ^5.4.3
    • firebase_ui_localizations ^1.13.0
    • firebase_ui_shared ^1.4.1
    • flutter any
  • intl 0.19.0
    • clock ^1.1.0
    • meta ^1.0.2
    • path ^1.8.0
  • community_material_icon 5.9.55
    • flutter any
  • flutter_local_notifications 18.0.0
    • clock ^1.1.0
    • flutter any
    • flutter_local_notifications_linux ^5.0.0
    • flutter_local_notifications_platform_interface ^8.0.0
    • timezone ^0.9.0
  • logger 2.4.0

Steps to reproduce

at line 122 of packages/firebase_ui_auth/lib/src/widgets/editable_user_display_name.dart there is an hardcoded string:

Subtitle(text: displayName ?? 'Unknown'),

Please localize it in firebase_ui_localizations

Expected Behavior

I expect that 'Unknown' string to be localized

Actual Behavior

'Unknown' string is hardcoded

Additional Information

No response

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Nov 17, 2024
@russellwheatley
Copy link
Member

Hey @alexodus - if you want to open a PR with this localization label update, I'd be happy to take a look 😄

@russellwheatley russellwheatley added auth blocked: customer response Waiting for customer response, e.g. more information was requested. platform: all and removed Needs Attention OP created or responded to issue and it needs attention. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth blocked: customer response Waiting for customer response, e.g. more information was requested. platform: all
Projects
None yet
Development

No branches or pull requests

2 participants