Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the samples as documented not functional #812

Open
coopernetes opened this issue Dec 1, 2024 · 0 comments · May be fixed by #811
Open

using the samples as documented not functional #812

coopernetes opened this issue Dec 1, 2024 · 0 comments · May be fixed by #811

Comments

@coopernetes
Copy link
Contributor

Describe the bug
Following these steps as documented in the plugin section is not functional in the current version of the sample package. This is caused by incorrect imports from the index.js ESM module-based sample.

Also a slight regression due to #793

Failed to load plugin: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@finos/git-proxy-plugin' imported from /home/tom/scratch/

To Reproduce
Steps to reproduce the behavior:

$ npm install @finos/git-proxy @finos/git-proxy-plugin-samples
npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated [email protected]: This package has been decomissioned. See https://github.com/ldapjs/node-ldapjs/blob/8ffd0bc9c149088a10ec4c1ec6a18450f76ad05d/README.md
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.

added 361 packages, and audited 362 packages in 13s

58 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

$ cp node_modules/@finos/git-proxy/proxy.config.json .
$ vim proxy.config.json
$ ./node_modules/.bin/git-proxy 
Failed to load plugin: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@finos/git-proxy-plugin' imported from /home/tom/scratch/
Found 0 plugin modules
creating user
        user=admin,
        gitAccount=none
        [email protected],
        admin=true
HTTP Proxy Listening on 8000
HTTPS Proxy Listening on 8443
Service Listening on 8080

Expected behavior
The samples should load successfully.

@coopernetes coopernetes linked a pull request Dec 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant