Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockForAuth should use the environment for hostname #674

Open
coopernetes opened this issue Aug 6, 2024 · 0 comments
Open

blockForAuth should use the environment for hostname #674

coopernetes opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@coopernetes
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When Git Proxy receives a push, it returns the following message:

remote: GitProxy has received your push βœ…
remote:
remote: πŸ”— Shareable Link
remote:
remote: http://localhost:8080/admin/push/0000000000000000000000000000000000000000__2e93519910ccf606190680f69a98a97a6c1ead26

When Git Proxy is deployed in a production environment, it should present the hostname of the real server instead of localhost.

Describe the solution you'd like
When Git Proxy receives a push and blocks for approval, it should return a message with the full server's URL. That URL should at least be configurable since there are too many variations of deployment methods.

Additional context
In most environments, Git Proxy will be deployed behind some sort of load balancer and will have a fully-qualified URL to access it as a developer.

@coopernetes coopernetes added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant