Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively disable TLS #658

Open
coopernetes opened this issue Jul 23, 2024 · 0 comments · May be fixed by #781
Open

Selectively disable TLS #658

coopernetes opened this issue Jul 23, 2024 · 0 comments · May be fixed by #781
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@coopernetes
Copy link
Contributor

After #558 , Git Proxy can no longer run without a private key & certificate available. Not all deployments are appropriate to run a direct TLS server such as when Git Proxy is deployed behind a shared load balancer or using a cloud SDN such as Envoy to encrypt app-to-app traffic at a host level.

I believe the intention behind that PR is still valid. Given how easy it is to generate a cert these days via LetsEncrypt, the project should provide HTTPS support for the app out of the box. However, it should be configurable to disable HTTPS if such a deployment is suitable.

@coopernetes coopernetes added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2024
@coopernetes coopernetes self-assigned this Jul 23, 2024
@YongNotYoung YongNotYoung linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant