FI-2833 Add R5 Support #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
author 360dgries <[email protected]> 1727189567 -0400 committer 360dgries <[email protected]> 1727360442 -0400 First rebase update fhir_models Update rubocop add generated files add one readme file add excluded_files add readme files update generator add tgz add expansion file add one readme file add readme files First rebase Fix r5 Model remove redundant file Add basic unit tests for R5 Add Unit tests and version from_contents update fhir_models Update rubocop add generated files add one readme file add excluded_files add readme files update generator add tgz add expansion file Fix r5 Model remove redundant file Add basic unit tests for R5 Add Unit tests and version from_contents
360dgries
force-pushed
the
FI-2833-r5
branch
from
65c88f8 to
64ef50f
Compare
| include FHIR::Json | ||
| include FHIR::Xml | ||
|
|
||
| SEARCH_PARAMS = [] |
There was a problem hiding this comment.
This is populated for other versions.
There was a problem hiding this comment.
Fixed. The problem is that SearchParameter.xpath is deprecated in R5. This also fixed some missing search parameters in R4!
.rubocop_todo.yml
Outdated
| - 'lib/fhir_models/r4b/fhir_ext/structure_definition.rb' | ||
| - 'lib/fhir_models/r4b/fhir_ext/structure_definition_compare.rb' | ||
| - 'lib/fhir_models/r4b/fhir_ext/structure_definition_finding.rb' | ||
| - 'lib/fhir_models/*/fhir_ext/structure_definition.rb' |
There was a problem hiding this comment.
Does this file even exist anywhere?
There was a problem hiding this comment.
file updated by rerun rubocop --auto-gen-config
.rubocop_todo.yml
Outdated
| - 'lib/fhir_models/fhir_ext/common_structure_definition.rb' | ||
| - 'lib/fhir_models/fhir_ext/common_structure_definition_compare.rb' | ||
| - 'lib/fhir_models/fhir_ext/common_structure_definition_finding.rb' | ||
| - 'lib/fhir_models/r5/fhir_ext/structure_definition.rb' |
There was a problem hiding this comment.
Some of these files still don't exist.
There was a problem hiding this comment.
This is auto generated. Maybe we should remove this file from git? It does not anything. I manually removed some lines as those are not there.
Jammjammjamm
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for FHIR R5:
excluded_files