From 92e98b3a5fb4d9ea0a4eceed910b54555b63cbe5 Mon Sep 17 00:00:00 2001
From: Kevin Olbrich <kevin.olbrich@mckesson.com>
Date: Sun, 15 Jan 2017 11:21:58 -0600
Subject: [PATCH] add specs for is_primitive?

---
 Guardfile                                    | 70 ++++++++++++++++++++
 fhir_models.gemspec                          |  1 +
 lib/fhir_models/bootstrap/model.rb           |  3 +
 spec/lib/fhir_models/bootstrap/model_spec.rb | 13 ++++
 4 files changed, 87 insertions(+)
 create mode 100644 Guardfile
 create mode 100644 spec/lib/fhir_models/bootstrap/model_spec.rb

diff --git a/Guardfile b/Guardfile
new file mode 100644
index 000000000..3215f0137
--- /dev/null
+++ b/Guardfile
@@ -0,0 +1,70 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.call("routing/#{m[1]}_routing"),
+      rspec.spec.call("controllers/#{m[1]}_controller"),
+      rspec.spec.call("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.call("features/#{m[1]}") }
+  watch(rails.layouts)       { |m| rspec.spec.call("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end
diff --git a/fhir_models.gemspec b/fhir_models.gemspec
index a1a3fcbb5..4eefcca70 100644
--- a/fhir_models.gemspec
+++ b/fhir_models.gemspec
@@ -34,4 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'nokogiri-diff'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'codeclimate-test-reporter'
+  spec.add_development_dependency 'guard-rspec'
 end
diff --git a/lib/fhir_models/bootstrap/model.rb b/lib/fhir_models/bootstrap/model.rb
index a91288018..8f0556af2 100644
--- a/lib/fhir_models/bootstrap/model.rb
+++ b/lib/fhir_models/bootstrap/model.rb
@@ -255,6 +255,9 @@ def validate_reference_type(ref, meta, contained_here, errors)
       errors << "#{meta['path']}: incorrect Reference type, expected #{meta['type_profiles'].map { |x| x.split('/').last }.join('|')}" unless matches_one_profile
     end
 
+    # TODO: this should be a class method
+    # TODO: this should be named `primitive?`
+    # TODO: perhaps this should validate against regexes if they are present
     def is_primitive?(datatype, value)
       # Remaining data types: handle special cases before checking type StructureDefinitions
       case datatype.downcase
diff --git a/spec/lib/fhir_models/bootstrap/model_spec.rb b/spec/lib/fhir_models/bootstrap/model_spec.rb
new file mode 100644
index 000000000..3a12f0a9d
--- /dev/null
+++ b/spec/lib/fhir_models/bootstrap/model_spec.rb
@@ -0,0 +1,13 @@
+describe 'FHIR::Model' do
+
+  describe '#is_primitive?' do
+
+    subject { FHIR::Patient.new({}) }
+
+    example 'integers' do
+      expect(subject.is_primitive?('integer', 0)).to be_true
+    end
+  end
+
+
+end