Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra search parameters defined #22

Open
Qining opened this issue Jul 29, 2019 · 0 comments
Open

Extra search parameters defined #22

Qining opened this issue Jul 29, 2019 · 0 comments

Comments

@Qining
Copy link

Qining commented Jul 29, 2019

For example: Appointment
Code:
https://github.com/fhir-crucible/fhir_dstu2_models/blob/master/lib/fhir_dstu2_models/fhir/resources/AppointmentResponse.rb#L8

Spec: https://www.hl7.org/fhir/DSTU2/appointment.html#search
There shouldn't be an 'appointment' parameter.

Similar issues with other resources:

  • Device:
    parent, source, category, parent, device, subject, etc

  • Communication:
    priority, requested, requester, time

  • Immunization:
    dose-number, information, support, vaccine-type

  • Medication:
    destination, dispenser, identifier, medication, patient, prescription, receiver, responsibleparty, status, type, whenhandedover, whenprepared, effectivedate, identifier, medication, patient, source, status, device, effectivetime, encounter, identifier, medication, notgiven, patient, practitioner, prescription, status, datewritten, encounter, identifier, medication, patient, prescriber, status

  • Procedure:
    orderer

  • Questionnaire:
    author, authored, encounter, patient, questionnaire, source, subject

  • Order:
    code, fulfillment, request, who, additive, datetime, encounter, formula, oraldiet, provider, status, supplement, code, datewritten, encounter, medication, prescriber, status, actor, bodysite, code, encounter, event-date, event-status, item-date, item-past-status, item-status, orderer, specimen, status

It looks like the code to generate the definition from the spec does a prefix match for the resource name, instead of an exact string match.
For example, the parameters for Questionnaire accidentally includes the parameters for QuestionnaireResposne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant