Deterministic ordering of objects when dumping

feincms · Oct 28, 2024 · 5b86412 · 5b86412
1 parent 85c737d
commit 5b86412
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,6 +7,8 @@ Change log
 
 - Added ``./manage.py f3dumpdata -`` which allows reading JSON data from stdin.
 - Added Python 3.12 and Django 5.0.
+- Order objects by their primary key when dumping specs. This helps with
+  comparing JSON files by hand.
 
 
 0.6 (2023-06-12)

diff --git a/feincms3_data/data.py b/feincms3_data/data.py
@@ -79,7 +79,7 @@ def specs_for_app_models(app, spec=None):
 
 
 def _model_queryset(spec):
-    queryset = apps.get_model(spec["model"])._default_manager.all()
+    queryset = apps.get_model(spec["model"])._default_manager.order_by("pk")
     if f := spec.get("filter"):
         queryset = queryset.filter(**f)
     return queryset