Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr/11726 recipeint filter fade message #4386

Open
wants to merge 21 commits into
base: qat
Choose a base branch
from

Conversation

jagu65
Copy link
Contributor

@jagu65 jagu65 commented Nov 21, 2024

High level description:
Added fade and search message to recipient filter.

Technical details:
The fade and the message will only show if there is no valid user input in the search box.

JIRA Ticket:
DEV-11726

Mockup:
Zeplin

The following are ALL required for the PR to be merged:

Author:

  • Linked to this PR in JIRA ticket
  • Scheduled demo including Design/Testing/Front-end OR Provided instructions for testing in JIRA and PR if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome extension)
  • Added Unit Tests for helper functions, reducers, models and Container/Component Interactivity Expectations if applicable React Testing Library
  • API contract updated if applicable
  • Component Library Integration Status Report updated if applicable

Reviewer(s):

  • Design review complete if applicable
  • API #1234 merged concurrently if applicable
  • Code review complete

Copy link
Contributor

@anjenkin anjenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be more padding here so the text isn't so close to the scroll bar? OR the better solution would be for the message to not be in the same container with the scrollable content, so the scrollbar doesn't obstruct the message. Either way is fine.

Screenshot 2024-11-26 104923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants