Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/1785 - Add trailing slash interceptor to prevent redirects #2390

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feature/1785 - Add trailing slash interceptor to prevent redirects #2390

wants to merge 2 commits into from

Conversation

sasha-dresden
Copy link
Contributor

@sasha-dresden sasha-dresden commented Nov 20, 2024 •
edited
Loading

Issue FECFILE-1785
API: PR1239

@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Nov 20, 2024
Open
toddlees
toddlees requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@toddlees toddlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't assume that all endpoints need a trailing slash.
image

For now we can correct the urls that are not matching what they should be on the api

@sasha-dresden sasha-dresden mentioned this pull request Dec 4, 2024
Open
@sasha-dresden sasha-dresden force-pushed the feature/1785 branch 3 times, most recently from dbf4315 to c6e8476 Compare December 5, 2024 16:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddlees toddlees toddlees requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasha-dresden @toddlees