Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1509 committee registration lookup uses only committee id #2144

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Feature/1509 committee registration lookup uses only committee id #2144

wants to merge 17 commits into from

Conversation

Elaine-Krauss-TCG
Copy link
Contributor

@Elaine-Krauss-TCG Elaine-Krauss-TCG commented Aug 26, 2024 •
edited
Loading

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lbeaufort lbeaufort changed the title Feature/1509 committee registration lookup uses only committee id [WIP] Feature/1509 committee registration lookup uses only committee id Oct 1, 2024
@Elaine-Krauss-TCG Elaine-Krauss-TCG mentioned this pull request Oct 2, 2024
Merged
@Elaine-Krauss-TCG Elaine-Krauss-TCG changed the title [WIP] Feature/1509 committee registration lookup uses only committee id Feature/1509 committee registration lookup uses only committee id Oct 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sasha-dresden
sasha-dresden reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@sasha-dresden sasha-dresden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about the Register button

front-end/src/app/committee/register-committee/register-committee.component.html
></app-error-messages>
</div>
<div class="col-3 no-horz-padding">
<button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in the wireframe the Register button is a search icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-dresden sasha-dresden sasha-dresden left review comments

@dheitzer dheitzer Awaiting requested review from dheitzer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elaine-Krauss-TCG @sasha-dresden