Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Delete' action for Loans and Debts and all associated transactions where Loan or Debt has transactions in future reports #2223

Closed
exalate-issue-sync bot opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
OBE Overcome by Events (duplicate, no longer needed, etc)

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Oct 1, 2024

Business Reason

As a user, I should not see the ‘Delete’ action in the dropdown for any Loan or Debt transaction where the Loan or Debt transaction/related transactions are on future reports, so that the transactions I report are accurate and complete

Acceptance Criteria

Given a Loan or Debt transaction

And the Loan or Debt has associated transactions in future reports

When the user selects the action kabob next to the transaction on the transactions table,

Then they will not see the ‘Delete’ action

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1658

Copy link
Author

akhorsand commented: Note that these transactions cannot be deleted, but the action is listed in the dropdown, which can be confusing for the user.

Copy link
Author

Sasha Dresden commented: API: fecgov/fecfile-web-api#1165
APP: #2329

Copy link
Author

Sasha Dresden commented: Completely reworked this. Now everything is happening inside a trigger and the can_delete property is back to only looking at the blocking_reports field.

Copy link
Author

Shelly Wise commented: [~accountid:61b0b42cd5986c006a9e1c94] per discussion with [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] please mark this ticket as OBE as [https://fecgov.atlassian.net/browse/FECFILE-1172|https://fecgov.atlassian.net/browse/FECFILE-1172|smart-link] is original ticket for this functionality. In process of making a bug to fix current error. Thanks!

Copy link
Author

akhorsand commented: Functionality captured in FECFILE-1172 , additional updates to be added in FECFILE-1829. Bug fix in the works to address repayments.

@exalate-issue-sync exalate-issue-sync bot added the OBE Overcome by Events (duplicate, no longer needed, etc) label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OBE Overcome by Events (duplicate, no longer needed, etc)
Projects
None yet
Development

No branches or pull requests

2 participants