Merge pull request #2428 from fecgov/feature/1782

feature/1782 - Removing unnecessary console.log

front-end/cypress/support/commands.ts

@@ -12,8 +12,6 @@ export function safeType(prevSubject: any, stringVal: string | number) {
 
   if (outString.length != 0) {
     subject.type(outString);
-  } else {
-    console.log(`Skipped typing into ${subject.toString()}} because the string was empty`);
   }
 
   return subject; //Allows Cypress methods to chain off of this command like normal (IE Cy.get().safe_type().parent().click() and so on)

front-end/src/app/reports/f3x/create-workflow/create-f3x-step1.component.spec.ts

@@ -178,7 +178,7 @@ describe('CreateF3XStep1Component', () => {
         { updateOn: 'blur' },
       );
       validator(group);
-      console.log(group.get('coverage_from_date')?.errors);
+
       expect(group.get('coverage_from_date')?.errors).toEqual(
         expectedFromMessage ? { invaliddate: { msg: expectedFromMessage } } : null,
       );

front-end/src/app/reports/transactions/transaction-detail/transaction-detail.component.spec.ts

@@ -86,7 +86,7 @@ describe('TransactionDetailComponent', () => {
     const saveSpy = spyOn(component, 'save');
 
     component.form.patchValue({ ...transaction, ...{ contributor_state: 'not-valid' } });
-    console.log('HEY LISTEN', component.form);
+
     component.handleNavigate(new NavigationEvent(NavigationAction.SAVE, NavigationDestination.LIST, transaction));
     expect(component.form.invalid).toBe(true);
     expect(navSpy).not.toHaveBeenCalled();

front-end/src/app/reports/transactions/transaction-list/select-report-dialog/select-report-dialog.component.spec.ts

@@ -92,11 +92,10 @@ describe('SelectReportDialogComponent', () => {
       component.selectedReport = component.availableReports[0];
       try {
         await component.createReattribution();
-      } catch {
-        console.log("shouldn't go here");
+      } finally {
+        const route = `/reports/transactions/report/${component.selectedReport.id}/create/${testScheduleATransaction.transaction_type_identifier}?reattribution=${testScheduleATransaction.id}`;
+        expect(routerSpy).toHaveBeenCalledWith(route);
       }
-      const route = `/reports/transactions/report/${component.selectedReport.id}/create/${testScheduleATransaction.transaction_type_identifier}?reattribution=${testScheduleATransaction.id}`;
-      expect(routerSpy).toHaveBeenCalledWith(route);
     });
   });
 });

front-end/src/app/shared/components/transaction-type-base/transaction-contact.utils.ts

@@ -166,7 +166,6 @@ export class TransactionContactUtils {
             config,
             transaction,
           );
-          console.log(contactChanges);
           // eslint-disable-next-line @typescript-eslint/no-explicit-any
           contactChanges.forEach(([property, value]: [keyof Contact, any]) => {
             contact[property] = value as never;

front-end/src/app/shared/components/transaction-type-base/transaction-form.utils.ts

@@ -242,8 +242,6 @@ export class TransactionFormUtils {
       ...formValues,
     });
 
-    console.log(payload);
-
     // The linkedF3xId form control is only present on the linked report input component
     // If this is present, we add its value as an ID to the payload's report ids
     const secondaryReportId = form.get('linkedF3xId')?.value;

front-end/src/app/shared/services/poller.service.ts

@@ -26,7 +26,6 @@ export class PollerService {
       const remoteMainScript = matchResponses && matchResponses.length > 0 ? matchResponses[1] : undefined;
 
       if (!remoteMainScript) {
-        console.log('Could not find main script in index.html');
         this.isNewVersionAvailable.next(false);
         return;
       }