Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django OIDC library with upstream changes and add unit tests run in CircleCI #601

Closed
15 of 17 tasks
lbeaufort opened this issue Nov 13, 2023 · 2 comments
Closed
15 of 17 tasks
Assignees

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Nov 13, 2023

Business Reason

Technical requirement: We're using a forked copy of the mozilla-django-oidc package. There have been some fixes since we forked a copy - we should incorporate upstream changes into our forked copy.

Ensure all unit tests pass and add meaningful test coverage before upgrading upstream changes.

Also, in the forked OIDC package perform the following code cleanup tasks:

QA Notes

null

DEV Notes

mozilla/mozilla-django-oidc#502

Design

null

See full ticket and images here: FECFILE-257

@mjtravers mjtravers changed the title Update Django OIDC library with upstream changes Update Django OIDC library with upstream changes and add unit tests run in CircleCI Feb 7, 2024
@lbeaufort lbeaufort self-assigned this Feb 9, 2024
@mjtravers
Copy link
Contributor

Passes CR. Sending to QA.

QA Notes: Ticket passes if user can login and logout of FECFile Online using Login.gov

@WiseQA
Copy link

WiseQA commented Feb 28, 2024

QA review consisted of visual inspection of Ticket passes if user can login and logout of FECFile Online using Login.gov built for this ticket per DEV.

QA Review Completed. Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants