Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example icon globally #3602

Closed
1 task
Tracked by #140
JonellaCulmer opened this issue Mar 10, 2020 · 2 comments · Fixed by #3828
Closed
1 task
Tracked by #140

Update example icon globally #3602

JonellaCulmer opened this issue Mar 10, 2020 · 2 comments · Fixed by #3828

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Mar 10, 2020

What we're after:
We've created a new icon to work for all example pages of varying types. The previous icon worked only for reporting examples. We need to update the icon used for examples, such as cards, globally.

Icon is here: https://drive.google.com/drive/folders/18kchMACk2e8QWxSi0jW4N04KNxi8CIii

Related issues

#3588 New icon for disclaimer example

Completion criteria

  • Example icon is replaced with the new icon globally
@rfultz
Copy link
Contributor

rfultz commented Jun 8, 2020

@JonellaCulmer

  • where can we see the current icon in use?
  • Is it a global replace or do we need to only replace it in certain places?
  • Should it be added to anyplace new (where the current icon isn't being used)?
  • Should we update the pattern library, too?

@rfultz rfultz self-assigned this Jun 8, 2020
@JonellaCulmer
Copy link
Contributor Author

@rfultz Here's a link to a place where the current icon is in use. See all the cards. https://www.fec.gov/help-candidates-and-committees/advertising-and-disclaimers/

This will be a global replacement to all current locations, not any place new, and we should definitely add it to the pattern library, if only the place that tracks all of our icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants