-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Stream impl for Dequeue #3
Comments
@khionu Thanks! I now implemented a An implementation for a
I'm leaning towards the first option, what do you think? |
I'm not sure how the first would function without reducing ergonomics? It wouldn't be able to be consumed within the iterator chain or loop blocks because you wouldn't be able to enforce a break of the loop. A custom Either is a very common approach, and given the nature of Par I think it would be very appropriate for it to have one. |
That's true, thanks! The first approach introduces a scope separation where it's not appropriate. I'll implement the second approach. |
Implemented: https://docs.rs/par/0.3.9/par/queue/struct.Dequeue.html#method.into_stream @khionu Let me know if anything is missing, or if this issue is now resolved! |
Implementing Iterator/Stream gives a lot of convenience, it would expand a lot of ergonomics to implement Stream on Dequeue.
The text was updated successfully, but these errors were encountered: