Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to clean backed up results #469

Open
sojusnik opened this issue Sep 30, 2024 · 3 comments
Open

Provide a way to clean backed up results #469

sojusnik opened this issue Sep 30, 2024 · 3 comments
Labels
S: triage Issue needs triage.

Comments

@sojusnik
Copy link

Would it be possible to add an option to do backups into a configurable global folder in addition to the existing option to save into a subfolder of the replaced file?

Maybe by allowing to provide a full path in the settings where you define the backup folder, like ~/Rummage-Backups or /tmp/Rummage? So when a full path is present, then the backups are always saved to the same global folder and not a subfolder any more?

@gir-bot gir-bot added the S: triage Issue needs triage. label Sep 30, 2024
@facelessuser
Copy link
Owner

Well, with a global folder, you could have issues where you could have multiple files with the same name (in different directories) overwriting each other. It gets tricky. Even if you try to preserve folder structure.

Is the problem that you find it difficult to clean up the folders or files afterwards? It's likely we could add a command to delete them all when you want to clean them up. I can understand that being an annoying problem, and a way to clean them up once you are satisfied you didn't destroy your documents might be nice.

To be honest, because most of the things I'm applying replace to are in version controlled repositories, I never enable backups as the version control systems make it easy to revert such changes.

@sojusnik
Copy link
Author

sojusnik commented Oct 1, 2024

Is the problem that you find it difficult to clean up the folders or files afterwards? It's likely we could add a command to delete them all when you want to clean them up. I can understand that being an annoying problem, and a way to clean them up once you are satisfied you didn't destroy your documents might be nice.

Yes, that's the main reason. So if cleaning up could be automated with the press of a button, that would do it too.

@facelessuser facelessuser changed the title Backups to global folder Provide a way to clean backed up results Oct 1, 2024
@facelessuser
Copy link
Owner

Yes, that's the main reason. So if cleaning up could be automated with the press of a button, that would do it too.

I can put that on my todo list then when I have some time. I imagine I would keep it fairly simple:

  • Access the clean up command from the menu
  • It would use the current working directly specified in the main dialog.
  • It would allow you to toggling traversing recursively, hidden folders, and symlinks.
  • You could specify folders to exclude (maybe these would be sourced from the main dialog as well).

Anyway, I think I know roughly what I want it to look like, I just will need to carve out the time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: triage Issue needs triage.
Projects
None yet
Development

No branches or pull requests

3 participants