Skip to content

Commit

Permalink
Fix moxygen OSS build
Browse files Browse the repository at this point in the history
Summary:
Fixes a breakage in the open source build of moxygen, see:

```
/Users/jcenzano/MetaOpenSource/moxygen/_build/deps/fizz/fizz/test/BogoShim.cpp:396:3: error: reference to 'gflags' is ambiguous
  396 |   gflags::ParseCommandLineFlags(&argc, &argv, true);
      |   ^
/Users/jcenzano/homebrew/include/gflags/gflags_gflags.h:41:11: note: candidate found by name lookup is 'gflags'
   41 | namespace gflags {
      |           ^
/Users/jcenzano/MetaOpenSource/moxygen/_build/deps/include/folly/portability/GFlags.h:124:11: note: candidate found by name lookup is 'folly::gflags'
  124 | namespace gflags = ::GFLAGS_NAMESPACE;
      |           ^
```

Reviewed By: afrind

Differential Revision: D66572281

fbshipit-source-id: fe02d944e07cbf4daf7b93bf4dc410226e99d10a
  • Loading branch information
jordicenzano authored and facebook-github-bot committed Dec 4, 2024
1 parent 6df1caf commit d9d632d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fizz/test/BogoShim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ int main(int argc, char** argv) {
}
}

gflags::ParseCommandLineFlags(&argc, &argv, true);
folly::gflags::ParseCommandLineFlags(&argc, &argv, true);
google::InitGoogleLogging(argv[0]);
CryptoUtils::init();

Expand Down

0 comments on commit d9d632d

Please sign in to comment.