Skip to content

Commit

Permalink
Cleanup ech policy from client context
Browse files Browse the repository at this point in the history
Summary: ECH policy on fizz client context is not used.

Reviewed By: rnandan08, mingtaoy

Differential Revision: D66400299

fbshipit-source-id: 84513859128aa337e2f73b2482124068886f2bf3
  • Loading branch information
abakiaydin authored and facebook-github-bot committed Dec 6, 2024
1 parent f614235 commit b0248ec
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion fizz/client/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ cpp_library(
],
exported_deps = [
":cert_manager",
":ech_policy",
":psk_cache",
"//fizz/compression:cert_decompression_manager",
"//fizz/protocol:certificate",
Expand Down
10 changes: 0 additions & 10 deletions fizz/client/FizzClientContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#pragma once

#include <fizz/client/CertManager.h>
#include <fizz/client/ECHPolicy.h>
#include <fizz/client/PskCache.h>
#include <fizz/compression/CertDecompressionManager.h>
#include <fizz/protocol/Certificate.h>
Expand Down Expand Up @@ -136,14 +135,6 @@ class FizzClientContext {
return certManager_;
}

void setECHPolicy(std::shared_ptr<ECHPolicy> echPolicy) {
echPolicy_ = std::move(echPolicy);
}

ECHPolicy* getECHPolicy() const {
return echPolicy_.get();
}

/**
* Set the Psk Cache to use.
*/
Expand Down Expand Up @@ -369,7 +360,6 @@ class FizzClientContext {

SendKeyShare sendKeyShare_{SendKeyShare::WhenNecessary};

std::shared_ptr<ECHPolicy> echPolicy_;
std::shared_ptr<PskCache> pskCache_;
std::shared_ptr<CertManager> certManager_{nullptr};
std::shared_ptr<CertDecompressionManager> certDecompressionManager_;
Expand Down

0 comments on commit b0248ec

Please sign in to comment.