Skip to content

Commit

Permalink
fix comment on legacy SigAlgs
Browse files Browse the repository at this point in the history
Summary: Land attempt was made before I saw mingtaoy's comment https://www.internalfb.com/diff/D66736193?dst_version_fbid=415120498346426&transaction_fbid=1789536688473353

Reviewed By: mingtaoy

Differential Revision: D66813426

fbshipit-source-id: 393d1fa3c9567df899817a7723a914a33c3075d9
  • Loading branch information
Yang Wang authored and facebook-github-bot committed Dec 6, 2024
1 parent 7400145 commit 22fc59c
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions fizz/record/Types.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,11 @@ std::string toString(SignatureScheme sigScheme) {
case SignatureScheme::rsa_pss_sha256_batch:
return "rsa_pss_sha256_batch";
}
// Handle legacy/compatibility algorithms
/**
* Fizz does not support these algorithms. They are listed
* here solely to aid in debugging when printing non-TLS 1.3
* ClientHellos (for example, in the fizzHandshakeFallback path)
*/
uint16_t val = static_cast<uint16_t>(sigScheme);
switch (val) {
// RSASSA-PKCS1-v1_5 algorithms
Expand All @@ -246,10 +250,7 @@ std::string toString(SignatureScheme sigScheme) {
return "rsa_pkcs1_sha384";
case 0x0601:
return "rsa_pkcs1_sha512";
// Fizz does not support these algorithms. They are listed
// here solely to aid in debugging when printing non-TLS 1.3
// ClientHellos (for example, in the fizzHandshakeFallback
// path)
// Legacy algorithms
case 0x0201:
return "rsa_pkcs1_sha1";
case 0x0203:
Expand Down

0 comments on commit 22fc59c

Please sign in to comment.