You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
We have duplicated code to generate the icons for the labels of required and optional fields. Let's refactor the code by adding constants for the characters used to display the checkmark and bullet point, and also create a helper function to generate the labels based on the value of their respective prop.
The text was updated successfully, but these errors were encountered:
Thanks for your interest to work on this, @manishbisht. RuleUtils.js looks like a good place for a helper function; so I'd be happy to a review a pull request.
Also, you could also create a separate React component that uses the helper function. Just a thought, though...
@pestevez I have added the RuleLabel Component and can you review the PR.
Once it is approved my next task will be to create a helped function in RuleUtils.js and then use the helper function to get the level so that the repeated code can be removed.
Requested by @mburak in #83
We have duplicated code to generate the icons for the labels of required and optional fields. Let's refactor the code by adding constants for the characters used to display the checkmark and bullet point, and also create a helper function to generate the labels based on the value of their respective prop.
The text was updated successfully, but these errors were encountered: