Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

A Problem about IsSimple be used in disassemble #303

Open
CcWeapon opened this issue Aug 11, 2022 · 0 comments
Open

A Problem about IsSimple be used in disassemble #303

CcWeapon opened this issue Aug 11, 2022 · 0 comments

Comments

@CcWeapon
Copy link

CcWeapon commented Aug 11, 2022

According to the definition of IsSimple, the function whose IsSimple is false is still disassembled in relocation mode.

  /// False if the function is too complex to reconstruct its control
  /// flow graph.
  /// In relocation mode we still disassemble and re-assemble such functions.
  bool IsSimple{true};

But as I read the code and tried it out, if a method is set to IsSimple=false in discoverFileObjects(), the method will be considered disassemble. The following code snippet ends at BinaryFunction::disassemable().

  if (!IsSimple) {
    clearList(Instructions);
    return false;
  }

Is this a bug, or am I misunderstood?

@maksfb

@CcWeapon CcWeapon changed the title A Problem about IsSimple A Problem about IsSimple be used in Aug 11, 2022
@CcWeapon CcWeapon changed the title A Problem about IsSimple be used in A Problem about IsSimple be used in disassemble Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant