Remove unused (Android) TextLayoutManager getter #48208
Closed
+18
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Differential Revision: D67059514
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
502b46b to
2bd830b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
2bd830b to
670aee7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Differential Revision: D67059514
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Differential Revision: D67059514
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
670aee7 to
0705846
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
0705846 to
49390b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 11, 2024
…48208) Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 12, 2024
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
49390b8 to
50a0194
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
Summary: [Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter This getter ``` void* getNativeTextLayoutManager() const; ``` is not used on Android and different in signature to the iOS one: ``` std::shared_ptr<void> getNativeTextLayoutManager() const; ``` Deleting it for now to make future code sharing between various platforms easier. This change removes further the by now discouraged pattern of: ``` using SharedTextLayoutManager = std::shared_ptr<const TextLayoutManager>; ``` and changes callers to use ``` std::shared_ptr<const TextLayoutManager>; ``` directly. Reviewed By: javache Differential Revision: D67059514
christophpurrer
force-pushed
the
export-D67059514
branch
from
50a0194 to
dd34f00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67059514 |
|
This pull request has been merged in 07d723c. |
|
This pull request was successfully merged by @christophpurrer in 07d723c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Remove unused (Android) TextLayoutManager getter
This getter
is not used on Android and different in signature to the iOS one:
Deleting it for now to make future code sharing between various platforms easier.
This change removes further the by now discouraged pattern of:
and changes callers to use
directly.
Differential Revision: D67059514