From 00c7174c24fd15db7723633e3e67aa59a7e73a6c Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Fri, 13 Dec 2024 16:44:01 -0800 Subject: [PATCH] Add override to RCTHermesInstance destructor (#48265) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48265 For some clang warnings configurations, you may hit `-Winconsistent-missing-destructor-override` without this override modifier. ## Changelog [Internal] Reviewed By: cipolleschi Differential Revision: D67203040 fbshipit-source-id: 51f8f9bc4e45ebdb008dc440b779302b1103668a --- .../react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h b/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h index f686220e69010e..86b7a2d717c96a 100644 --- a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h +++ b/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h @@ -30,7 +30,7 @@ class RCTHermesInstance : public JSRuntimeFactory { std::unique_ptr createJSRuntime( std::shared_ptr msgQueueThread) noexcept override; - ~RCTHermesInstance(){}; + ~RCTHermesInstance() override{}; private: CrashManagerProvider _crashManagerProvider;