Exclude React Compiler runtime from inline requires #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
cc @robhogan |
|
also cc @poteto fyi |
robhogan
approved these changes
Nov 17, 2024
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #1126. This call is in every component on every render and it is not beneficial to inline it. On the contrary, you want to reduce the indirection there.
Changelog: [Performance] Exclude React Compiler runtime from inline requires
Changelog:
Test plan
Before:
After: