Improved resource cleanup #226
Conversation
Under Linux, re-opening the Plotter within a peristent context may not deallocate resources. Allow this via an explicit .close() method. Hardware tests added: - Verify that we can re-open the device without I/O errors (in fact, ValueErrors) - Added umockdev_mode config flag to skip safe_write. Allows to run with umockdev-run.
|
@hackfin thank you for this PR proposing further advancement of this plugin. Can you elaborate more on how to reproduce your issue |
|
Re-opening the plotter after closing the device (deletion) obviously frees not all USB resources (claims, probably). Upon reopening, a not so verbose 'ValueError' is raised, eventually. I don't know about Mac and Windows (yet). The user story is that I'm driving this plugin from other software (like Blender) and reopening files requires some cleanup. For reproduction with attached hardware, see test scenario: https://github.com/hackfin/inkscape-silhouette/blob/5f5942337b9aef1764bc138ab1b3962f29986ed2/test/hardware/test_io.py#L53 Since this PR broke the tests though, I've probably got some homework to do in order to supply passing umockdev tests for the github actions. Does anyone have input on how to get mocked hardware tested within the github pipeline? |
Under Linux, re-opening the Plotter within a peristent context may not deallocate resources. Allow this via an explicit .close() method.
Hardware tests added:
Addendum: I am looking into some class restructuring such that the silhouette can be used by other front ends plus facilitation of derival such that no functionality is broken or compatibility is disrupted. Roughly, this would:
Graphtecclass into a hierarchy, avoiding product code comparison within member functionsGraphtecinto a function call that returns the properly detected classOpinions?
For verification, more umockdev ioctl traces would be required and a reference test to be added. I currently have access to a cameo3 only. Appreciating any 'foreign' ioctl files for further I/O verification to start with (test_io.py).