Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify DIIS Solvers #115

Open
JonathonMisiewicz opened this issue Aug 18, 2021 · 0 comments
Open

Unify DIIS Solvers #115

JonathonMisiewicz opened this issue Aug 18, 2021 · 0 comments
Labels
cleanup The code can be made a bit cleaner

Comments

@JonathonMisiewicz
Copy link
Contributor

The SPQE DIIS solver and the DIIS solver in maths/optimizer.py are near identical. They differ only in some extra variable setting they do after the end of the actual DIIS. We should determine how much of the variable setting should be synchronized between the two of them and unify the codes, to eliminate the duplication.
@JonathonMisiewicz JonathonMisiewicz added the cleanup The code can be made a bit cleaner label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup The code can be made a bit cleaner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonathonMisiewicz