From 6da56ef31c0c57943fabc6191ed6f2c5d47a9146 Mon Sep 17 00:00:00 2001 From: Bernhard Mallinger Date: Thu, 8 Aug 2024 09:11:11 +0200 Subject: [PATCH] Set papermill autosave-every to 60 In the previous commit a049a09fc0c0018d6b1db69d0a11dd6612bca83b , setting this to 0 was intended as a mitigation for possible concurrent writes, but there is now evidence that running out of memory leads to PermissionDenied when saving notebooks (it's reproducible in one case) The autosave-every setting should lead to better debuggability and getting info about the notebook state quicker during execution. --- CHANGELOG.md | 3 +++ pygeoapi_kubernetes_papermill/notebook.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 931194a..fc3d09b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +## 1.5.0 +* Set autosave-every to 60 + ## 1.4.0 * Implement pagination diff --git a/pygeoapi_kubernetes_papermill/notebook.py b/pygeoapi_kubernetes_papermill/notebook.py index 58feeb8..782a120 100644 --- a/pygeoapi_kubernetes_papermill/notebook.py +++ b/pygeoapi_kubernetes_papermill/notebook.py @@ -259,7 +259,7 @@ def create_job_pod_spec( f'"{output_notebook}" ' "--engine kubernetes_job_progress " "--request-save-on-cell-execute " - "--autosave-cell-every 0 " + "--autosave-cell-every 60 " f'--cwd "{working_dir(requested.notebook)}" ' + ("--log-output " if self.log_output else "") + (f"-k {requested.kernel} " if requested.kernel else "")