Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(gentest): ensure the generated python test module passes tox checks #859

Open
Tracked by #866
danceratopz opened this issue Oct 2, 2024 · 0 comments · May be fixed by #901
Open
Tracked by #866

✨(gentest): ensure the generated python test module passes tox checks #859

danceratopz opened this issue Oct 2, 2024 · 0 comments · May be fixed by #901
Labels
scope:gentest Scope: gentest CLI type:feat type: Feature

Comments

@danceratopz
Copy link
Member

Currently, if a test module is generated via:

uv run gentest -c config.json 0xa41f343be7a150b740e5c939fa4d89f3a2850dbe21715df96b612fc20d1906be tests/paris/test_0xa41f.py

the generated test module tests/paris/test_0xa41f.py doesn't pass the flake8 and mypy checks when running tox (uvx --with=tox-uv tox).

For example:

uv run mypy tests/paris/test_0xa41f.py
tests/paris/test_0xa41f.py:67: error: Need type annotation for "post" (hint: "post: Dict[<type>, <type>] = ...")  [var-annotated]

We should ensure that no manual processing or fixes are necessary for tox (and CI) to pass. It should just work ™️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:gentest Scope: gentest CLI type:feat type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant