Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing #247

Open
antazoey opened this issue Nov 2, 2022 · 2 comments
Open

Add typing #247

antazoey opened this issue Nov 2, 2022 · 2 comments
Assignees

Comments

@antazoey
Copy link
Contributor

antazoey commented Nov 2, 2022

  • Version: 0.7.0b1
  • Python: 3.9.13
  • OS: macOS

What was wrong?

Include typing so downstream libraries can use without having to place type: ignore statements on the imports.

e.g.

from eth_tester.exceptions import TransactionFailed  # type: ignore

How can it be fixed?

Including type declarations everywhere + a py.typed file in the core source directory.

@DavidRomanovizc
Copy link
Contributor

@pacrob, over the past year, there has been no activity here. Could you confirm the relevance/necessity of this issue, and if so, I am prepared to attempt to do it?

@pacrob
Copy link
Contributor

pacrob commented Jan 11, 2024

@DavidRomanovizc Typing is still desired here. I'll get a pr in soon to start the typing and make it easier to add typing file by file, and will make note of it in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants