-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is library masking all gas estimation errors as TransactionFailed
?
#168
Comments
It should still be re-raising those exceptions, just with a common exception type. Is that not he behavior you're seeing? |
I see only reraised |
👍 we should fix this to ensure that this information is properly preserved. Thanks for reporting this. |
The fix for this is going to involve removal of the |
I could make some PR, if you provide description how this suppose to work and where related tests are located. |
Version: 0.1.0b39
eth_tester
is masking all errors on gas estimation asTransactionFailed
. This does lose information about problem type (revert or opcode problem) and revert message. That is not very convenient for debugging, because developer does not get any information about contract error.Here is related code:
https://github.com/ethereum/eth-tester/blob/master/eth_tester/backends/pyevm/main.py#L463
What is the reason for such behavior?
The text was updated successfully, but these errors were encountered: