Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to debian 12 bookworm #16462

Closed
3 tasks done
Tracked by #15951
jmhbnz opened this issue Aug 23, 2023 · 2 comments
Closed
3 tasks done
Tracked by #15951

Upgrade to debian 12 bookworm #16462

jmhbnz opened this issue Aug 23, 2023 · 2 comments

Comments

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2023

What would you like to be added?

Debian 12 "bookworm" was released in June 2023. We should consider updating etcd project from debian 11 "bullseye".

The Kubernetes project has already made a start on this, refer: kubernetes/release#3128.

For us this would involve:

  • Updating the container: used in .github/workflows/ files.
-    container: golang:1.20-bullseye
+    container: golang:1.20-bookworm
  • Updating the .devcontainer/devcontainer.json used for etcd container based development environments.
-       "image": "mcr.microsoft.com/devcontainers/go:1.20-bullseye",
+       "image": "mcr.microsoft.com/devcontainers/go:1.20-bookworm",
  • Update the FROM: base image in our Dockerfile.
-FROM --platform=linux/${ARCH} gcr.io/distroless/static-debian11
+FROM --platform=linux/${ARCH} gcr.io/distroless/static-debian12

Why is this needed?

Ensure etcd releases, testing workflows and container based development use a modern base image.

Avoid any potential future technical debt and uncover any potential issues early.

@jmhbnz
Copy link
Member Author

jmhbnz commented Sep 1, 2023

The initial work for this has now been completed in #16516.

@ahrtr, @serathius what are your thoughts on backporting this? My thinking is we would only do so if for some reason bullseye was broken or out of support. Keen to double check before I close this though.

@jmhbnz
Copy link
Member Author

jmhbnz commented Sep 4, 2023

Closing as the initial pr is complete and my instinct is we shouldn't backport this change.

Happy to re-open if my assessment isn't right 🙏🏻

@jmhbnz jmhbnz closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant