[VRChat → VRM] Blinkのシェイプキーがnoneの場合に例外が発生するのを修正 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ェイプキーがnoneの場合に例外が発生するのを修正
PancakeTorto1se
force-pushed
the
fix_blink_shapekey_is_none
branch
from
7db91c8 to
86ccd01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 のissueについて修正のPRを作成しました。
こちらの問題の原因ですが、VRC Avatar DescriptorのEye Look→Eyelids→Blendshape StatesのBlinkが
-none-になっている場合に以下の
settings.eyelidsBlendshapes[0]が-1になるためIndex out of rangeが発生していました。VRMConverterForVRChat/Editor/Utilities/VRChatUtility.cs
Line 332 in 1891517
したがって、本修正ではこの値が設定されている場合に無視するようにしています。