Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes broken by new GUI #654

Open
6 of 9 tasks
lantis1008 opened this issue Sep 9, 2017 · 19 comments
Open
6 of 9 tasks

Themes broken by new GUI #654

lantis1008 opened this issue Sep 9, 2017 · 19 comments

Comments

@lantis1008
Copy link
Contributor

lantis1008 commented Sep 9, 2017

Need to bring themes inline with new UI
Assigning this to myself, but happy for anyone to assist.

@lantis1008
Copy link
Contributor Author

Provided basic screenshots to assist

@d3fz
Copy link
Contributor

d3fz commented Sep 12, 2017

How's the progress so far ? I'm having a go with "Xeye" (halfway there) and "Theme by Matei", based on your changes to Light/Green Themes.

screencapture-192-168-1-1-access-sh-1505179939691

Not sure how to approach "Demantoid"/"Horchata" due to custom menu layout.

@lantis1008
Copy link
Contributor Author

Thanks for doing that.
I'm also avoiding those two for that exact reason, but I will get to them eventually.
I'm having a look at cleaning Gargoyle-Modern as it got kind of forgotten in the process of getting Gargoyle-Classic up to spec.

@d3fz
Copy link
Contributor

d3fz commented Sep 12, 2017

No problem.
Xeye is pretty much finished.
Having a look at the other one now.

Edit: almost there.
screencapture-192-168-1-1-access-sh-1505267281220

@d3fz
Copy link
Contributor

d3fz commented Sep 13, 2017

By default, these themes were all centered with width ~ 900px, "wasting" useful available space.
Should we make then full-width or leave as it is ?

Just need to make sure it doesn't break when going mobile, and some minor tweaks.

After that is pretty much finished.

@lantis1008
Copy link
Contributor Author

Agreed. I made them 1300px wide (if I remember correctly) to give the same feel as the old themes, whilst maximising space.
This size auto shrinks as the window does, so no usability issues with the themes I've done.

up to you, if you want a new spin on it which is full width and not centered, go for it.

@d3fz
Copy link
Contributor

d3fz commented Sep 13, 2017

Yes, increasing max-width to 1300px makes it a lot better, so i'm just gonna leave as it is. I actually like the centered layout.

Once i'm finished, where/how can i send it to you ?

@lantis1008
Copy link
Contributor Author

You can create your own PR if you like, or send via a file sharing site etc. no problem

@d3fz
Copy link
Contributor

d3fz commented Sep 14, 2017

I've tried to match them as close as possible without breaking anything, looking pretty close.

There you go: https://ufile.io/726bh

I'm sending via shared file so you can take a look and perhaps include into your already opened PR.

I've also added two additional .png files:

  1. Modified "favicon.png" (transparent background). I got it from another user who posted a theme on the forum. It's an improvement over the current one, imo.
  2. Compressed (lossless) "globe-and-flags.png". Drops from 13kb to 5kb.

Let me know what you think.

@lantis1008
Copy link
Contributor Author

That all sounds good.
Will check and review this evening.
Thanks

@Joro711
Copy link

Joro711 commented Apr 17, 2020

I see this in theme Flat blue. No text. Any ideas?
img-2020-04-17-16-04-38

@lantis1008
Copy link
Contributor Author

Was fixed by commit 904cb16
Would need to install from an updated package repository. Or make the change manually yourself (it is only a few lines).

@Joro711
Copy link

Joro711 commented Apr 17, 2020

Thank you! Where i get update ipk file or how to change manually css file? Sorry for my bad english!

@lantis1008
Copy link
Contributor Author

Either by building it yourself, or using a build provided on the forums.
Manually changing the css file is just done by changing the file at /www/themes/flat-blue/theme.css to include the additional lines from 904cb16
You can make those changes using something like WinSCP or SSH, using the guides on the forums: https://www.gargoyle-router.com/phpbb/viewtopic.php?f=8&t=8505

@stopspazzing
Copy link
Contributor

@lantis1008 I think it's about time I finish the modern gargoyle theme. Is the color scheme staying the same as is? Any specific changes/suggestions? Compiling latest build now...

@lantis1008
Copy link
Contributor Author

Welcome back
Colour scheme as you please. Having it at least somewhat resemble the Gargoyle purples would be great, but that is what Gargoyle classic is for so no stress.

@Joro711
Copy link

Joro711 commented Aug 22, 2023

I have a new question. How do I install the Flat Blue theme in OpenWRT when I can't find it in the package repository? Gargoyle has it and it installs successfully.

@lantis1008
Copy link
Contributor Author

You want to install a Gargoyle theme in regular OpenWrt?
You can't.

@Joro711
Copy link

Joro711 commented Aug 23, 2023

Understand you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants