plot() outputs require white background (or white lines?) for dark mode website

[avallecam]

currently, the plot() outputs are lost in the background. possibly the standard suggested action item would be to try to keep the default white background.

[Bisaloo]

Can you share the link to the page where you are observing this please?

[avallecam]

Can you share the link to the page where you are observing this please?

yes, here it is https://epiverse-trace.github.io/epiparameter/articles/data_from_epireview.html

[Bisaloo]

I see the same behaviour in pkgdown: https://pkgdown.r-lib.org/articles/test/rendering.html

Could you please open a new issue there (after checking if it hasn't been reported already)? I'm curious to see if they consider it's a bug / something that needs to be changed upstream or if they prefer leave it to end users.

[avallecam]

Could you please open a new issue there (after checking if it hasn't been reported already)?

sure!

[avallecam]

now reported in r-lib/pkgdown#2729

[Bisaloo]

Note to self: only base plots are affected, not ggplot plots.

[avallecam]

I'm curious to see if they consider it's a bug / something that needs to be changed upstream or if they prefer leave it to end users.

they prefer to leave this to end users using par(bg = 'white').

So, should we add this parameter to all vignettes expecting that it may generate base R plots? This would give it an output similar to ggplot2 visualizations

(screenshot from PR preview adding this to the testing vignette)

[avallecam]

update: maybe we can wait until the discussion on their side gets to a conclusion to plan a next step.