-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a common contact data class across packages #55
Comments
I'm not 100% convinced that they need to be separate but if yes then it would indeed be a great idea to streamline the interface to be similar. We might also want to consider whether they could be named better to make the distinction clearer (as
That is a good idea I think. |
Outcome from the discussion that happened on slack: It looks we heading towards a separate package which will provide a constructor and other methods ( The maintainers of the individual packages keep the responsibility to convert their objects to the common class. This means we should probably sync with conmat devs to see if:
|
Hi there 👋 Just chiming in to notify myself of this discussion, and also tagging in the other conmat devs, @goldingn, and @aarathybabu97 |
As above. Commenting for notifications on progress here. |
I think the different packages fill different niches and it's good to keep them all alive (especially since they are already on CRAN).
However, we should make sure that they play well together and that it is easy for users to go from one to the other.
It might also be useful to provide a shared S3 class for contact matrices so we can write common methods.
See also: Bisaloo/contactdata#2
The text was updated successfully, but these errors were encountered: