Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to select Erase tool after expanding macromolecule abbreviation in Micro mode and console errors appear #5662

Open
Zhirnoff opened this issue Oct 7, 2024 · 1 comment · Fixed by #5759 · May be fixed by #5794
Open

Unable to select Erase tool after expanding macromolecule abbreviation in Micro mode and console errors appear #5662

Zhirnoff opened this issue Oct 7, 2024 · 1 comment · Fixed by #5759 · May be fixed by #5794
Assignees
@svvald
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Milestone
Ketcher 2.26.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 7, 2024

Steps to Reproduce

  1. Open file in Macro mode (Flex mode) monomers-cycled.zip
  2. Switch to Micro mode
  3. Expand AspOMe and try select an Erase tool

Actual behavior
After expanding a macromolecule abbreviation, it becomes impossible to select the Erase tool. Additionally, errors start appearing in the DevTools Console, indicating an issue with the tool or the expansion process.

Expected behavior
The Erase tool should be selectable and functional, allowing users to erase elements on the canvas without any issues.

Videos

2024-10-07_15h59_57.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]
Bug found during testing: #5400
@Zhirnoff Zhirnoff added bug Priority: High Macro-Micro Bucket: Macro-Micro View related issues labels Oct 7, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@svvald svvald self-assigned this Oct 10, 2024
svvald added a commit that referenced this issue Oct 15, 2024
@svvald
#5662 – Fix inability to select Erase tool after monomer expansion
bf44d0a
svvald added a commit that referenced this issue Oct 16, 2024
@svvald
#5662 – Fix inability to select Erase tool after monomer expansion (#…
d58f18d 
…5759)
@rrodionov91 rrodionov91 linked a pull request Oct 16, 2024 that will close this issue
#5662 – Fix inability to select Erase tool after monomer expansion #5759
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-10-16_18h28_26.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.3]
Indigo version
[Version 1.25.0-rc.2]

svvald added a commit that referenced this issue Oct 17, 2024
@svvald
#5662 – Fix inability to select Erase tool after monomer expansion
cb9d836
@svvald svvald linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5662 – Fix inability to select Erase tool after monomer expansion #5794
Open
9 tasks
svvald added a commit that referenced this issue Oct 18, 2024
@svvald
#5662 – Fix inability to select Erase tool after monomer expansion
52dc146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Projects
None yet
Milestone
Ketcher 2.26.0-rc.3
3 participants
@svvald @rrodionov91 @Zhirnoff