mount: ensure the root’s ref prop gets attached to the actual root
#2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the root’s `ref` prop gets attached to the actual root Fixes enzymejs#2253.
ljharb
added
semver: patch
package: react adapter: 16
package: react adapter: 15
package: react adapter: 15.4
package: react adapter: 0.14
package: react adapter: 0.13
package: enzyme-adapter-utils
package: react adapter: 16.1
package: react adapter: 16.2
package: react adapter: 16.3
labels
ljharb
changed the title
mount: ensure the root’s ref prop gets attached to the actual rootmount: ensure the root’s ref prop gets attached to the actual root
ljharb
force-pushed
the
fix_mount_refs
branch
from
0ccee2f
to
7836e57
Compare
ljharb
added a commit
that referenced
this pull request
Oct 10, 2019
- [fix] `mount`: ensure the root’s `ref` prop gets attached to the actual root (#2259) - [refactor] remove unused code from createMountWrapper; add tests - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `airbnb-prop-types`, `function.prototype.name`, `object.fromentries`, `semver` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-plugin-react`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `rimraf`, `safe-publish-latest`
ljharb
added a commit
that referenced
this pull request
Oct 10, 2019
- [fix] `mount`: ensure the root’s `ref` prop gets attached to the actual root (#2259) - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `react-is`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-plugin-react`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `rimraf`, `safe-publish-latest`
ljharb
added a commit
that referenced
this pull request
Oct 10, 2019
- [fix] `mount`: ensure the root’s `ref` prop gets attached to the actual root (#2259) - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `enzyme-adapter-utils`, `react-is` - [dev deps] update `eslint`, `eslint-plugin-react`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `rimraf`, `safe-publish-latest`
ljharb
added a commit
that referenced
this pull request
Oct 10, 2019
- [fix] `mount`: ensure the root’s `ref` prop gets attached to the actual root (#2259) - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `enzyme-adapter-utils`, `react-is` - [dev deps] update `eslint`, `eslint-plugin-react`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `rimraf`, `safe-publish-latest`
ljharb
added a commit
that referenced
this pull request
Oct 11, 2019
- [fix] `mount`: ensure the root’s `ref` prop gets attached to the actual root (#2259) - [deps] update `enzyme-adapter-utils`, `react-is`
|
Isn't this exactly what I wanted to do in #2101 originally which wasn't deemed backwards compat safe? |
I won't have the time for that. But thanks for releasing this. Allowed us to remove a couple of seemingly useless fragments 👍 |
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2253.
After merging, this will need adapter-utils bumped and published, and then every adapter's minimum utils version bumped, and then they'll also need a publish.