Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using Output splitting tool on big joblists #649

Open
umfuz opened this issue Nov 11, 2024 · 1 comment
Open

Crash when using Output splitting tool on big joblists #649

umfuz opened this issue Nov 11, 2024 · 1 comment
Labels

Comments

@umfuz
Copy link

umfuz commented Nov 11, 2024

Describe the bug
I'm trying to join my flac collection grouping the files by their metadata using the Output splitting tool. With big enough joblists (e.g. 1000 tracks) the app closes unexpectedly. This doesn't happen for small enough joblists (e.g. 100 tracks). I've tried the Flatpak stable and the AppImage stable and continuous releases. Also could reproduce the problem on Windows with the stable release.

To Reproduce
Steps to reproduce the behavior:

  1. Open fre:ac
  2. Load a big joblist of flac files
  3. Select FLAC encoder with default settings
  4. Enable Create cue sheet and Encode to single file
  5. Open the Output splitting tool, select Split by metadata
  6. Pattern to compare: <albumartist>,<album>,<year>,<disc>
  7. Filename pattern: <albumartist>/<year> - <album> CD<disc(2)>
  8. Hit convert on the Output splitting tool window
  9. The app crashes, sometimes inmediately and sometimes it manages to create some files, maybe depending on the joblist size

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information)

  • OS: Debian 12 Stable, using Flatpak fre:ac version 1.1.7
  • CPU: AMD Ryzen 5 Pro 5650U
  • RAM: 16 GB

Additional context
Also tried with the AppImages and on Windows, similar outcome.

@umfuz umfuz added the bug label Nov 11, 2024
@umfuz
Copy link
Author

umfuz commented Nov 12, 2024

I think it might be an issue of resource handling. If I disable 'Parallel processing', then although slower it runs succesfully on bigger joblists. It will still crash if I add all the files at once, but I managed to get the job done by batches. Given this, I think it could be related to #563.

I guess it wouldn't hurt to mention that I have without issues converted my whole collection to AAC and Opus using fre:ac, so this specific job of merging FLACs seems to trigger the problem more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant