-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: fix ipFamily always nil #4782
base: main
Are you sure you want to change the base?
Conversation
8c45abb
to
e029e70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
=======================================
Coverage 65.61% 65.62%
=======================================
Files 211 211
Lines 31989 31997 +8
=======================================
+ Hits 20991 20999 +8
+ Misses 9760 9759 -1
- Partials 1238 1239 +1 ☔ View full report in Codecov by Sentry. |
@@ -463,6 +463,7 @@ func (t *Translator) addRouteToRouteConfig( | |||
ea := &ExtraArgs{ | |||
metrics: metrics, | |||
http1Settings: httpListener.HTTP1, | |||
ipFamily: httpListener.IPFamily, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect, you are using the listener level IPFamily
value in the cluster
you should be deriving this value using a new IPFamily
field in
https://github.com/envoyproxy/gateway/blame/48a0310082ceeaf4d3af17e6b6844c7d0fb5db0b/internal/ir/xds.go#L1297 instead and this should be set in the gateway api layer using the Backend Service / EndpointSlice info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I’ve updated the code to use a new IPFamily field
cc @zirain
816a1fe
to
f620e41
Compare
Signed-off-by: Juwon Hwang (Kevin) <[email protected]>
f620e41
to
64f4832
Compare
chore: fix ipFamily always nil
What this PR does / why we need it:
This PR improves IP family configuration handling across different listener types and updates the DNS lookup strategy for better dual-stack support.
Which issue(s) this PR fixes:
Fixes #4761