Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set cookies attributes for keys without values #4679

Open
arkodg opened this issue Nov 8, 2024 · 1 comment
Open

Unable to set cookies attributes for keys without values #4679

arkodg opened this issue Nov 8, 2024 · 1 comment
Labels
kind/decision A record of a decision made by the community.
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Nov 8, 2024

Description:

Describe the issue.

The current API for setting cookie attributes in the consistent hashing configuration is a map[string]string

Attributes map[string]string `json:"attributes,omitempty"`

The RFC https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.1 as well as Envoy Proxy https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-routeaction-hashpolicy-cookieattribute support an optional value , which is seen in well known attributes such as Secure and HttpOnly
https://datatracker.ietf.org/doc/html/rfc6265#section-5.2.6

There are a few ways to address this issue

  1. Add a new field e.g. attributesList that supports optional values

or

  1. Add first class fields for the well known cookie attributes such as Secure and HttpOnly

or

  1. Breaking change to attributes field to support optional values

Relates to https://envoyproxy.slack.com/archives/C03E6NHLESV/p1730397571965609

@arkodg arkodg added the triage label Nov 8, 2024
@arkodg arkodg added this to the Backlog milestone Nov 8, 2024
@arkodg arkodg added the kind/decision A record of a decision made by the community. label Nov 8, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Nov 8, 2024

ptal @envoyproxy/gateway-maintainers

@arkodg arkodg removed the triage label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/decision A record of a decision made by the community.
Projects
None yet
Development

No branches or pull requests

1 participant