Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egg building tests leave 'build' directories behind #542

Closed
mdickinson opened this issue Mar 17, 2023 · 2 comments
Closed

Egg building tests leave 'build' directories behind #542

mdickinson opened this issue Mar 17, 2023 · 2 comments
Milestone

Comments

@mdickinson
Copy link
Member

Some of our tests dynamically build eggs. With current versions of setuptools and pip, that results in build directories being left behind in the source tree. We should be cleaning those build directories up. (The lack of cleanup is currently hidden by our .gitignore; we may want to fix this.)

@mdickinson mdickinson added this to the Release 7.0 milestone Mar 17, 2023
@mdickinson
Copy link
Member Author

We should also clean up the egg-info directories created.

@mdickinson
Copy link
Member Author

mdickinson commented Mar 22, 2023

Let's punt on this - it's not causing any real issues. We're already excluding build and egg-info directories in .gitignore, and all of the egg building machinery should be going away in Envisage 8.0 anyway. (xref: #548)

For the record, this was causing issues at one point during development because the built eggs were picking up the build directories as part of the package, leading to a several-layers-deep recursive inclusion of build directories. #543 fixed this particular issue by introducing specific inclusions in the find_packages calls in setup scripts.

@mdickinson mdickinson closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant