Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct initial timestep temperature in heat-fluids solver for transients #13

Open
paulromano opened this issue May 15, 2019 · 2 comments

Comments

@paulromano
Copy link
Member

Moving issue 27 from gitlab originally submitted by @aprilnovak:

The CoupledDriver currently only has a notion of solutions at the current and previous Picard iterations. The heat-fluids solver is usually run as a transient, which performs timestepping based on some solution at the start of the timestep. This initial solution from which the T/H solver marches forward in time should be the same as the CoupledDriver::temperature_ at the start of each timestep if we ever want to run transients (for pseudo-transients where we simulate to a steady state instead of solving PDEs with no time derivatives, the initial condition is irrelevant).

At the start of each timestep in CoupledDriver, we should tell the T/H solver what temperature it should use as the initial condition for that timestep. We can add a temperature_prev_ member to the HeatDriver and NekDriver to represent the temperature at the last timestep.

@RonRahaman
Copy link
Collaborator

PR #35 will move the temperature update functions into CoupledDriver. I can see that being a good starting point for this issue. Thoughts?

@aprilnovak
Copy link
Contributor

The update_temperature method only updates the temperature known to the coupled driver, i.e. the Picard iteration temperatures. We would need to add some method to Nek's interface like nek_set_temperature(int elem) to tell Nek's solver what temperature to begin marching from.

But given a conversation a while ago that transients aren't a priority, this issue is low on the to-do list since Nek should converge on a single steady temperature solution regardless of whatever IC it has internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants