Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo 49 - Breaking Changes #111

Open
hazirmagron opened this issue Jul 19, 2023 · 19 comments · May be fixed by #112
Open

Expo 49 - Breaking Changes #111

hazirmagron opened this issue Jul 19, 2023 · 19 comments · May be fixed by #112
Labels
bug Something isn't working

Comments

@hazirmagron
Copy link

Describe the bug
The overlay is completely broken since I updated to Expo@49.

The 'HoldItem' child components still animate when pressed. The overlay and menu never show up, however, and the child component that was pressed is frozen on the screen.

Package versions

  • React: "18.2.0"
  • React Native: "0.72.3"
  • React Native Reanimated: "~3.3.0"
  • React Native Hold Menu: "^0.1.6"
  • Expo: "^49.0.0"
@hazirmagron hazirmagron added the bug Something isn't working label Jul 19, 2023
@holma91
Copy link

holma91 commented Aug 19, 2023

Is this fixed yet?

@pavelbabenko
Copy link

Same issue

@raymond-tetteh
Copy link

I have the same issue.

@mimo-10
Copy link

mimo-10 commented Sep 16, 2023

got the same issue her, any solutions suggested?

@Nasseratic
Copy link

Nasseratic commented Sep 25, 2023

Hello guys 👋🏼

I am working on a fix here 🤓 #112

It's WIP, but I got everything working on my project

@moedeveloper
Copy link

Unfortunately same issue :(

@svatkowski
Copy link

Hey, is there a fixed version ? I saw the new PR being WIP and changes seems to works perfecly. Did you already publish it ? Or still WIP ? Thanks ✌️

@Nasseratic
Copy link

Nasseratic commented Oct 15, 2023

Hey @devmalcolm

Yeah, it should be ready. But I can't publish it as I am not a contributor. Will try to bring someone to approve my PR. For now feel free to install the version in the PR by:

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

@viktor32
Copy link

@Nasseratic great job, thank you!

But I think the correct command to install from your repo is (with the branch where the fix)

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

@BennoCrafter
Copy link

Hey @Nasseratic! I've downloaded your updated version, but sadly it still doesnt work. Is it just me, or is it because there is a new version?

@MathiasSvDK
Copy link

Same issue. Using expo 50

@mimo-10
Copy link

mimo-10 commented Mar 30, 2024

It works, you only need to use this version
npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
And you need to make a change inside the backdrop component in order to make it work on android.
Just change View, to AnimatedBlurView

@BennoCrafter
Copy link

Just for android?

@mimo-10
Copy link

mimo-10 commented Mar 30, 2024

Yes, you need to do that only for android, for ios it works without any changes.

@tconroy
Copy link

tconroy commented Jun 21, 2024

Im having trouble trying to install this fork.. 🤔 any ideas?

❯ npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
zsh: no matches found: https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

@Nasseratic
Copy link

@tconroy It works for me 😅

@tconroy
Copy link

tconroy commented Jun 21, 2024

@tconroy It works for me 😅

Yes I just needed to wrap the url as a string and now it works 😊

@daxaxelrod
Copy link

Can we merge the upgrade to 49 (also confirming nasseratic's fix works on expo 50) to main

@BraeschAntoine
Copy link

Thx your solution worked perfectly, your fork saved my day ! I don't understand why this isn't already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet