Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-26798: Remove Lerna and refine run scripts #3248

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Jun 27, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

After #3166, 'npm run bootstrap' does not link internal packages automatically.

Resolution

As we use npm higher than 7 now, we can use npm workspaces.

  • Updated our monorepo to use npm workspaces
  • Removed Lerna as we do not use any complex function of Lerna
  • Made 'npm install' to make an internal link also
  • Made 'npm run clean' to remove 'node_modules' of the root path also
  • Removed 'npm run publish' as we don't use it anymore
  • But, kept the existing run scripts rather than removing them for any scripts
  • Updated a related document

Additional Considerations

Links

WRQ-26798

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])

0x64 added 4 commits June 27, 2024 11:35
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (1e444a8) to head (a55a973).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3248      +/-   ##
===========================================
- Coverage    82.48%   79.48%   -3.01%     
===========================================
  Files          157      157              
  Lines         7247     7247              
  Branches      1919     1919              
===========================================
- Hits          5978     5760     -218     
- Misses         998     1171     +173     
- Partials       271      316      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hong6316
hong6316 previously approved these changes Jun 28, 2024
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
But please fix the travis fail

@hong6316 hong6316 dismissed their stale review June 28, 2024 02:23

travis fail

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants