Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRO-478: POC for item reordering in VirtualList #3076

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Jul 26, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

POC for item reordering in VirtualList

Resolution

The former POC implementation of #3027 is totally refined.

  • Changed to wait for press-and-hold input to edit items' order
  • Changed to get a single object-typed editable prop rather than several individual props

Additional Considerations

There are so many bugs and missing behaviors.

  • Touch input is not supported yet.
  • UI could be broken or ugly when boundaries are changed.
  • It is unstable when various input devices are used simultaneously.
  • I cannot guarantee that it works great even with a single input device.
  • Performance optimization is required.

Links

WRO-478 (companion enactjs/sandstone#1293)
WRN-17866 (#3027)

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #3076 (700d63b) into develop (700d63b) will not change coverage.
The diff coverage is n/a.

❗ Current head 700d63b differs from pull request most recent head cf4403a. Consider uploading reports for the commit cf4403a to get more accurate results

@@           Coverage Diff            @@
##           develop    #3076   +/-   ##
========================================
  Coverage    48.10%   48.10%           
========================================
  Files          171      171           
  Lines         9717     9717           
  Branches      2609     2609           
========================================
  Hits          4674     4674           
  Misses        3956     3956           
  Partials      1087     1087           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700d63b...cf4403a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant